It really depends on the setting. My uniform is 501's, and I naturally tend to display a fairly noticeable package, not only meat, but also potatoes. If I'm going to be out in the general public I will consciously choose the right underwear and pack it in such a way that it's not too obvious and not showing too much detail. Commando or boxers, forget it, just plain obscene. Same thing with dress pants, briefs or trunks are a must. If I'm on the beach or out with the boys shooting pool it's a different story. Don't really put it out on display, but don't go to extraordinary lengths to hide it either.
Living in California where people are athletic and casually dressed you get used to seeing lots of revealing attire. I was in Starbuck's one day, and there was a guy in white lycra bike shorts, sweat soaked so they were semi-transparent. I was sitting, he was standing, so his package was right at eye level. Talk about 'in your face'. He was well-endowed, and I could practically count the veins on his dick. Everybody was staring, and though he acted unaware, I suspect he was getting off on the attention. Though I personally thought it looked hot, it was way beyond socially acceptable and appropriate, imo. I bike and wear the shorts too sometimes, not see-thru, and I wrap a shirt around my waist if I go into a business. Showing a decent bulge is one thing - putting yourself on display for the whole world, however titillating, is really crass in my opinion. Ultimately, it comes down to the audience.